-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48356: [GLib][Ruby] Add missing options classes #48357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-48356: [GLib][Ruby] Add missing options classes #48357
Conversation
|
|
|
The |
4620142 to
83251e0
Compare
|
Another issue I ran into was that the |
|
Thanks! But could you split this large PR to smaller PRs? I can't review this... Could you use one issue/PR per option class? For example, I'm using #48132 is an umbrella issue for pure Ruby Apache Arrow implementation. |
I'll implement it in the gobject-introspection gem later. |
|
There is one commit per option class to make it easier to review. The reason I created a single PR is that 32 of the commits adds code to the same place. This means that when it is time to merge you would get conflicts for all of these. Also, two of them needs the 33rd commit (FixedSizeListArray) for the tests to pass. Do you still want me to create separate PRs? |
|
Yes. If you use one large PR, we can't merge this until we're ready all options. If any of them has a problem, we can't merge all of them. I can't review large PR multiple times. |
|
You don't need to open 32 PRs at a time. You can open a few PR at once. You can open more PRs after they are merged. |
|
That makes sense. I will close this and open separate PRs. |
Rationale for this change
Many compute functions are missing their corresponding options class in the GLib bindings. Many functions can still be used in Ruby with reduced functionality, but some functions like
extract_regexcannot be used at all.What changes are included in this PR?
The following options classes are added to the GLib bindings:
The following classes are added as well since they were needed in some tests:
Are these changes tested?
All classes are tested with Ruby unit tests.
Are there any user-facing changes?
Yes, new classes.